Messages in this thread | | | Date | Sat, 5 Jun 2021 21:20:23 -0500 | From | Bjorn Andersson <> | Subject | Re: [PATCH v2 1/4] arm64: dts: qcom: sc7280: Add PCIe nodes for IDP board |
| |
On Sat 05 Jun 09:40 CDT 2021, Prasad Malisetty wrote:
> Add PCIe nodes for sc7280 IDP board. >
This looks good, but it can't come before patch 2 in the series, which introduces these labels.
Regards, Bjorn
> Signed-off-by: Prasad Malisetty <pmaliset@codeaurora.org> > --- > arch/arm64/boot/dts/qcom/sc7280-idp.dts | 28 ++++++++++++++++++++++++++++ > 1 file changed, 28 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dts b/arch/arm64/boot/dts/qcom/sc7280-idp.dts > index 3900cfc..a58552b 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dts > +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dts > @@ -268,6 +268,34 @@ > }; > }; > > +&pcie1 { > + status = "okay"; > + > + vdda-supply = <&vreg_l10c_0p8>; > +}; > + > +&pcie1_phy { > + status = "okay"; > + > + vdda-phy-supply = <&vreg_l10c_0p8>; > + vdda-pll-supply = <&vreg_l6b_1p2>; > +}; > + > +&pcie1_default_state { > + clkreq { > + bias-pull-up; > + }; > + > + wake-n { > + drive-strength = <2>; > + bias-pull-up; > + }; > + > + nvme-n { > + bias-pull-up; > + }; > +}; > + > &qupv3_id_0 { > status = "okay"; > }; > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project >
| |