Messages in this thread | | | Date | Sat, 5 Jun 2021 08:43:30 +0200 | From | Greg KH <> | Subject | Re: [PATCH] HID: sony: fix freeze when inserting ghlive ps3/wii dongles |
| |
On Fri, Jun 04, 2021 at 12:10:23PM -0400, Pascal Giard wrote: > This commit fixes a freeze on insertion of a Guitar Hero Live PS3/WiiU > USB dongle. Indeed, with the current implementation, inserting one of > those USB dongles will lead to a hard freeze. I apologize for not > catching this earlier, it didn't occur on my old laptop. > > While the issue was isolated to memory alloc/free, I could not figure > out why it causes a freeze. So this patch fixes this issue by > simplifying memory allocation and usage. > > We remind that for the dongle to work properly, a control URB needs to > be sent periodically. We used to alloc/free the URB each time this URB > needed to be sent. > > With this patch, the memory for the URB is allocated on the probe, reused > for as long as the dongle is plugged in, and freed once the dongle is > unplugged. > > Signed-off-by: Pascal Giard <pascal.giard@etsmtl.ca> > --- > drivers/hid/hid-sony.c | 98 +++++++++++++++++++++--------------------- > 1 file changed, 49 insertions(+), 49 deletions(-)
<formletter>
This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly.
</formletter>
| |