Messages in this thread | | | Date | Sat, 5 Jun 2021 16:19:59 -0700 | From | Dmitry Torokhov <> | Subject | Re: [PATCH][next] Input: resistive-adc-touch: Fix uninitialized variable 'press' |
| |
Hi Colin,
On Thu, Jun 03, 2021 at 11:08:09PM +0100, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > In the case where st->ch_map[GRTS_CH_PRESSURE] < GRTS_MAX_CHANNELS is false > and also st->ch_map[GRTS_CH_Z1] < GRTS_MAX_CHANNELS is false the variable > press is not initialized and contains garbage. This affects a later > comparison of press < st->pressure_min.
If neither of the conditions is true, then st->pressure is also false, and we will not be evaluating condition involving "press". However it is impossible for the compiler/Coverity to figure this out, so I'll apply the patch adjusting the description a bit.
Thanks.
-- Dmitry
| |