| Date | Sat, 5 Jun 2021 15:42:22 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH 5.10 235/252] ALSA: usb-audio: scarlett2: snd_scarlett_gen2_controls_create() can be static |
| |
Hi!
> From: kernel test robot <lkp@intel.com> > > [ Upstream commit 2b899f31f1a6db2db4608bac2ac04fe2c4ad89eb ] > > sound/usb/mixer_scarlett_gen2.c:2000:5: warning: symbol 'snd_scarlett_gen2_controls_create' was not declared. Should it be static? > > Fixes: 265d1a90e4fb ("ALSA: usb-audio: scarlett2: Improve driver startup messages") > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: kernel test robot <lkp@intel.com> > Link: https://lore.kernel.org/r/20210522180900.GA83915@f59a3af2f1d9 > Signed-off-by: Takashi Iwai <tiwai@suse.de> > Signed-off-by: Sasha Levin <sashal@kernel.org>
We normally require real, legal names for commit authors and signoffs. I guess it is a bit late now, but... we don't take pseudonyms so we should not take robots.
Best regards, Pavel -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany [unhandled content-type:application/pgp-signature] |