| Date | Sat, 5 Jun 2021 12:50:53 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH Part1 RFC v3 04/22] x86/mm: Add sev_feature_enabled() helper |
| |
On Wed, Jun 02, 2021 at 09:03:58AM -0500, Brijesh Singh wrote: > @@ -78,6 +85,7 @@ static inline void sev_es_init_vc_handling(void) { } > static inline bool sme_active(void) { return false; } > static inline bool sev_active(void) { return false; } > static inline bool sev_es_active(void) { return false; } > +static inline bool sev_snp_active(void) { return false; }
Leftover from the previous version, can go.
> +bool sev_feature_enabled(unsigned int type) > +{ > + switch (type) { > + case SEV: return sev_status & MSR_AMD64_SEV_ENABLED; > + case SEV_ES: return sev_status & MSR_AMD64_SEV_ES_ENABLED; > + case SEV_SNP: return sev_status & MSR_AMD64_SEV_SNP_ENABLED; > + default: return false; > + } > +}
Yeah, btw, we might even do a generic one, see:
https://lkml.kernel.org/r/YLkcIuL2qvo0hviU@zn.tnic
and the following mail.
But that doesn't matter as sev_feature_enabled()'s body can go into sev_protected_guest_has() or whatever we end up calling it.
Thx.
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
|