lkml.org 
[lkml]   [2021]   [Jun]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] tools/testing/nvdimm: use vzalloc() instead of vmalloc()/memset(0)
Date
Wu Bo <wubo40@huawei.com> writes:

> Use vzalloc() instead of vmalloc() and memset(0) to simpify
> the code.
>
> Signed-off-by: Wu Bo <wubo40@huawei.com>
> ---
> tools/testing/nvdimm/test/nfit.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)

LGTM,

Reviewed-by: Santosh S <santosh@fossix.org>

>
> diff --git a/tools/testing/nvdimm/test/nfit.c b/tools/testing/nvdimm/test/nfit.c
> index 54f367cbadae..258bba22780b 100644
> --- a/tools/testing/nvdimm/test/nfit.c
> +++ b/tools/testing/nvdimm/test/nfit.c
> @@ -1625,7 +1625,6 @@ static void *__test_alloc(struct nfit_test *t, size_t size, dma_addr_t *dma,
> if (rc)
> goto err;
> INIT_LIST_HEAD(&nfit_res->list);
> - memset(buf, 0, size);
> nfit_res->dev = dev;
> nfit_res->buf = buf;
> nfit_res->res.start = *dma;
> @@ -1652,7 +1651,7 @@ static void *test_alloc(struct nfit_test *t, size_t size, dma_addr_t *dma)
> struct genpool_data_align data = {
> .align = SZ_128M,
> };
> - void *buf = vmalloc(size);
> + void *buf = vzalloc(size);
>
> if (size >= DIMM_SIZE)
> *dma = gen_pool_alloc_algo(nfit_pool, size,
> --
> 2.30.0

\
 
 \ /
  Last update: 2021-06-04 08:50    [W:0.061 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site