lkml.org 
[lkml]   [2021]   [Jun]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH V3 4/9] tracing/hwlat: Implement the per-cpu mode
From
Date
On 6/3/21 11:17 PM, Steven Rostedt wrote:
> On Fri, 14 May 2021 22:51:13 +0200
> Daniel Bristot de Oliveira <bristot@redhat.com> wrote:
>
>> void trace_hwlat_callback(bool enter)
>> {
>> - if (smp_processor_id() != nmi_cpu)
>> + struct hwlat_kthread_data *kdata = get_cpu_data();
>> +
>> + if (kdata->kthread)
>
> Shouldn't that be:
>
> if (!kdata->kthread)

oops! Fixing in v4.

-- Daniel


> ?
>
> -- Steve
>
>> return;
>>
>> /*
>> @@ -158,13 +173,13 @@ void trace_hwlat_callback(bool enter)
>> */
>> if (!IS_ENABLED(CONFIG_GENERIC_SCHED_CLOCK)) {
>> if (enter)
>> - nmi_ts_start = time_get();
>> + kdata->nmi_ts_start = time_get();
>> else
>> - nmi_total_ts += time_get() - nmi_ts_start;
>> + kdata->nmi_total_ts += time_get() - kdata->nmi_ts_start;
>> }
>>
>> if (enter)
>> - nmi_count++;
>> + kdata->nmi_count++;
>> }
>>
>

\
 
 \ /
  Last update: 2021-06-04 17:31    [W:0.961 / U:0.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site