Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Fri, 4 Jun 2021 15:18:22 +0200 | Subject | Re: [PATCH] mmc: renesas_sdhi: Fix HS400 on R-Car M3-W+ |
| |
Hi Wolfram,
On Fri, Jun 4, 2021 at 3:16 PM Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > On Fri, Jun 04, 2021 at 02:59:43PM +0200, Geert Uytterhoeven wrote: > > R-Car M3-W ES3.0 is marketed as R-Car M3-W+ (R8A77961), and has its own > > compatible value "renesas,r8a77961". > > > > Hence using soc_device_match() with soc_id = "r8a7796" and revision = > > "ES3.*" does not actually match running on an R-Car M3-W+ SoC. > > > > Fix this by matching with soc_id = "r8a77961" instead. > > > > Fixes: a38c078fea0b1393 ("mmc: renesas_sdhi: Avoid bad TAP in HS400") > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > Great, thanks for this fix! > > > Boot-tested on Salvator-XS with R-Car M3-W+ ES3.0. > > No difference seen in eMMC/SHHC detection: > > You'd need some stress testing plus debug output of the TAPs chosen to > actually see a difference. However, the patch is obviously correct. > Testing if soc_id actually matches now is good enough.
FTR, I did check that part.
> Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Thanks!
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |