lkml.org 
[lkml]   [2021]   [Jun]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next v6 3/5] page_pool: Allow drivers to hint on SKB recycling
[...]
> > + /* Driver set this to memory recycling info. Reset it on recycle.
> > + * This will *not* work for NIC using a split-page memory model.
> > + * The page will be returned to the pool here regardless of the
> > + * 'flipped' fragment being in use or not.
> > + */
>
> I am not sure I understand how does the last part of comment related
> to the code below, as there is no driver using split-page memory model
> will reach here because those driver will not call skb_mark_for_recycle(),
> right?
>

Yes the comment is there to prohibit people (mlx5 only actually) to add the
recycling bit on their driver. Because if they do it will *probably* work
but they might get random corrupted packets which will be hard to debug.

> > + page->pp = NULL;
> > + page_pool_put_full_page(pp, virt_to_head_page(data), false);
> > +
> > + return true;
> > +}
> > +EXPORT_SYMBOL(page_pool_return_skb_page);
>

\
 
 \ /
  Last update: 2021-06-04 10:44    [W:0.079 / U:0.840 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site