lkml.org 
[lkml]   [2021]   [Jun]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] genirq: Provide new interfaces for affinity hints
    On Fri, May 21, 2021 at 5:48 PM Thomas Gleixner <tglx@linutronix.de> wrote:
    >
    > On Fri, May 21 2021 at 12:13, Nitesh Lal wrote:
    > > On Fri, May 21, 2021 at 8:03 AM Thomas Gleixner <tglx@linutronix.de> wrote:
    > >> Provide new interfaces:
    > >>
    > >> irq_update_affinity_hint() - Only sets the affinity hint pointer
    > >> irq_apply_affinity_hint() - Set the pointer and apply the affinity to
    > >> the interrupt
    > >>
    > >
    > > Any reason why you ruled out the usage of irq_set_affinity_and_hint()?
    > > IMHO the latter makes it very clear what the function is meant to do.
    >
    > You're right. I was trying to phase the existing hint setter out, but
    > that's probably pointless overengineering for no real value. Let me redo
    > that.
    >

    Thomas, are you planning to send a v2 for this soon or did I somehow miss
    it?

    Since your other patch "genirq: Export affinity setter for modules" is
    already in linux-next, I have started looking into the drivers where
    we can use that.

    On thinking about this whole chunk a little more, I do wonder about the
    reason why we are still sticking with the hints.

    The two reasons that I could come up with are:
    - We are not entirely sure if irqbalance still consumes this or not
    - For future use by some other userspace daemon (?)

    Does that sound right?

    --
    Thanks
    Nitesh

    \
     
     \ /
      Last update: 2021-06-04 22:37    [W:2.227 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site