Messages in this thread | | | From | Andy Shevchenko <> | Date | Wed, 30 Jun 2021 21:23:30 +0300 | Subject | Re: [PATCH v3] gpio: tegra186: Add ACPI support |
| |
On Wed, Jun 30, 2021 at 9:17 PM Akhil R <akhilrajeev@nvidia.com> wrote: > > Add ACPI module ID to probe the driver from the ACPI based bootloader > firmware.
Thanks for an update, my comments below. After addressing, feel free to add Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Change-Id: Id8e892f989e4ccc935b87aa0d84b10a3d1efd8f9
This is not for upstream.
> Signed-off-by: Akhil Rajeev <akhilrajeev@nvidia.com>
...
> +static const struct acpi_device_id tegra186_gpio_acpi_match[] = { > + { .id = "NVDA0108", .driver_data = (kernel_ulong_t)&tegra186_main_soc }, > + { .id = "NVDA0208", .driver_data = (kernel_ulong_t)&tegra186_aon_soc }, > + { .id = "NVDA0308", .driver_data = (kernel_ulong_t)&tegra194_main_soc }, > + { .id = "NVDA0408", .driver_data = (kernel_ulong_t)&tegra194_aon_soc },
> + {},
Comma is not needed for terminator lines.
> +}; > +MODULE_DEVICE_TABLE(acpi, tegra186_gpio_acpi_match);
-- With Best Regards, Andy Shevchenko
| |