Messages in this thread | | | Subject | Re: [PATCH] powercap: Replace symbolic permissions with octal permissions | From | Joe Perches <> | Date | Wed, 30 Jun 2021 11:00:12 -0700 |
| |
On Wed, 2021-06-30 at 19:41 +0200, Rafael J. Wysocki wrote: > On Thu, Jun 24, 2021 at 10:44 AM Jinchao Wang <wjc@cdjrlc.com> wrote: > > > > Resolve following checkpatch issue, > > Replace symbolic permissions with octal permissions > > I don't see much value in this replacement and checkpatch complaining > about the existing code base is not something to worry about in > general.
https://lore.kernel.org/lkml/CA+55aFw5v23T-zvDZp-MmD_EYxF8WbafwwB59934FV7g21uMGQ@mail.gmail.com/
I do agree that in general checkpatch should not really be used as the sole argument in favor of changing existing code.
So removing the "resolve following checkpatch issue" from the commit message and replacing it with something like "to improve readability" would be better.
| |