Messages in this thread | | | From | jim.cromie@gmail ... | Date | Wed, 30 Jun 2021 10:38:57 -0600 | Subject | Re: [PATCH 1/3] checkpatch: skip spacing tests on linker scripts |
| |
On Tue, Jun 29, 2021 at 2:01 PM Joe Perches <joe@perches.com> wrote: > > On Tue, 2021-06-29 at 13:50 -0600, jim.cromie@gmail.com wrote: > > this does 3 different things > > > > - non-capturing matches - these add no functionality, > > true, it's nominally a bit faster through. > > > - moves the skip-remaining-tests check after SPDX > > that feels like a legal Q: should it be on all files ? > > moving it does seem proper though. > > to me too. > > > - adds the skip linker-script > > since i went ahead and added it 3 times to see errs/warns > > I didnt consider your precise placement, > > how does it do with 18/8 errs/warnings on ref-test ? > > $ ./scripts/checkpatch.pl -f include/asm-generic/vmlinux.lds.h --strict --terse
cool options. <Aside> some oddities are hidden there; Im seeing the err/warn counts change along with use of those options. not a big deal, but it is mildly surprising forex: $ scripts/checkpatch.pl -f include/asm-generic/vmlinux.lds.h --terse ... total: 18 errors, 7 warnings, 1164 lines checked $ scripts/checkpatch.pl -f include/asm-generic/vmlinux.lds.h --terse --strict ... total: 9 errors, 7 warnings, 95 checks, 1164 lines checked
> include/asm-generic/vmlinux.lds.h:1: WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 > include/asm-generic/vmlinux.lds.h:43: WARNING: please, no space before tabs > include/asm-generic/vmlinux.lds.h:101: CHECK: line length of 106 exceeds 100 columns > include/asm-generic/vmlinux.lds.h:390: WARNING: please, no space before tabs > include/asm-generic/vmlinux.lds.h:546: ERROR: code indent should use tabs where possible > total: 1 errors, 3 warnings, 1 checks, 1184 lines checked >
2nd one is I think pedantic comment formatting, but on the whole, fair complaints. and I see your insertion spot is right between my 2 picks. works for me.
just to note, this is about a generalization of
commit 263afd39c06f5939ef943e0d535380d4b8e56484 Author: Chris Down <chris@chrisdown.name> Date: Thu Feb 25 17:22:04 2021 -0800
checkpatch: don't warn about colon termination in linker scripts
| |