lkml.org 
[lkml]   [2021]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v5 01/17] drm/amd/display: Remove unnecessary SIGNAL_TYPE_HDMI_TYPE_A check
    Date
    Remove unnecessary SIGNAL_TYPE_HDMI_TYPE_A check that was performed in the
    drm_mode_is_420_only() case, but not in the drm_mode_is_420_also() &&
    force_yuv420_output case.

    Without further knowledge if YCbCr 4:2:0 is supported outside of HDMI,
    there is no reason to use RGB when the display
    reports drm_mode_is_420_only() even on a non HDMI connection.

    This patch also moves both checks in the same if-case. This eliminates an
    extra else-if-case.

    Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
    ---
    drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 5 +----
    1 file changed, 1 insertion(+), 4 deletions(-)

    diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
    index 10f878910e55..e081dd3ffb5f 100644
    --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
    +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
    @@ -5348,10 +5348,7 @@ static void fill_stream_properties_from_drm_display_mode(
    timing_out->v_border_bottom = 0;
    /* TODO: un-hardcode */
    if (drm_mode_is_420_only(info, mode_in)
    - && stream->signal == SIGNAL_TYPE_HDMI_TYPE_A)
    - timing_out->pixel_encoding = PIXEL_ENCODING_YCBCR420;
    - else if (drm_mode_is_420_also(info, mode_in)
    - && aconnector->force_yuv420_output)
    + || (drm_mode_is_420_also(info, mode_in) && aconnector->force_yuv420_output))
    timing_out->pixel_encoding = PIXEL_ENCODING_YCBCR420;
    else if ((connector->display_info.color_formats & DRM_COLOR_FORMAT_YCRCB444)
    && stream->signal == SIGNAL_TYPE_HDMI_TYPE_A)
    --
    2.25.1
    \
     
     \ /
      Last update: 2021-06-30 17:11    [W:2.702 / U:0.200 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site