Messages in this thread | | | Date | Wed, 30 Jun 2021 16:15:43 +0200 | From | Michael Walle <> | Subject | Re: [PATCH v1] mtd: spi-nor: Add support for XM25QH64C |
| |
Am 2021-06-28 06:55, schrieb Tudor.Ambarus@microchip.com: > On 6/14/21 9:56 AM, Michael Walle wrote: >> EXTERNAL EMAIL: Do not click links or open attachments unless you know >> the content is safe >> >> Hi Reto, >> >> Am 2021-06-13 14:12, schrieb Reto Schneider: >>> From: Reto Schneider <reto.schneider@husqvarnagroup.com> >>> >>> The data sheets can be found here: >>> http://xmcwh.com/Uploads/2020-12-17/XM25QH64C_Ver1.1.pdf >> >> Could you add that as a "Datasheet:" tag before your Sob tag? >> >>> This chip has been (briefly) tested on the MediaTek MT7688 based >>> GARDENA >>> smart gateway. >> >> Could you also apply my SFDP patch [1] and send the dump? >> Unfortunately, >> I can't think of a good way to do that along with the patch and if >> this >> in some way regarded as copyrighted material. So feel free to send it >> to >> me privately. I'm starting to build a database. >> > > Can the SFDP dump fit in the commit message when introducing a new > flash ID?
As ASCII hex dump? I'd guess we need some instructions how to do that. 4k would be 256 lines with 16 byte per line.
But yes, I had the same thought.
> The SFDP standard is public. SFDP reveals just what the flash > supports, why would that be sensitive information?
copyright material must not be sensitive information, no? I'm no laywer, thus I'd played it safe.
> Reto, would you please dump the SFDP tables here?
FWIW, he already provided me a binary dump for the flash (actually for the former version, too) and its already in my DB which you should have access, too.
If we mandate that (and I am all for it) for new flashes, we will have to come up with a common format. Something like
echo "-----BEGIN SFDP (JEDEC ID ...)------" cat sfdp | xxd -ps -c 20 echo "-----END SFDP------"
I really don't know if such meta data belongs into the commit logs, though.
-michael
| |