Messages in this thread Patch in this message | | | Date | Wed, 30 Jun 2021 13:47:50 -0000 | From | "tip-bot2 for Paul E. McKenney" <> | Subject | [tip: core/rcu] torture: Fix remaining erroneous torture.sh instance of $* |
| |
The following commit has been merged into the core/rcu branch of tip:
Commit-ID: 98da77199f0c629f0687b92824f1da2010f677e3 Gitweb: https://git.kernel.org/tip/98da77199f0c629f0687b92824f1da2010f677e3 Author: Paul E. McKenney <paulmck@kernel.org> AuthorDate: Thu, 04 Mar 2021 14:15:00 -08:00 Committer: Paul E. McKenney <paulmck@kernel.org> CommitterDate: Mon, 10 May 2021 16:05:05 -07:00
torture: Fix remaining erroneous torture.sh instance of $*
Although "eval" was removed from torture.sh, that commit failed to update the KCSAN instance of $* to "$@". This results in failures when (for example) --bootargs is given more than one argument. This commit therefore makes this change.
There is one remaining instance of $* in torture.sh, but this is used only in the "echo" command, where quoting doesn't matter so much.
Fixes: 197220d4a334 ("torture: Remove use of "eval" in torture.sh") Signed-off-by: Paul E. McKenney <paulmck@kernel.org> --- tools/testing/selftests/rcutorture/bin/torture.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/rcutorture/bin/torture.sh b/tools/testing/selftests/rcutorture/bin/torture.sh index 56e2e1a..53ec7c0 100755 --- a/tools/testing/selftests/rcutorture/bin/torture.sh +++ b/tools/testing/selftests/rcutorture/bin/torture.sh @@ -302,7 +302,7 @@ function torture_set { kcsan_kmake_tag="--kmake-args" cur_kcsan_kmake_args="$kcsan_kmake_args" fi - torture_one $* --kconfig "CONFIG_DEBUG_LOCK_ALLOC=y CONFIG_PROVE_LOCKING=y" $kcsan_kmake_tag $cur_kcsan_kmake_args --kcsan + torture_one "$@" --kconfig "CONFIG_DEBUG_LOCK_ALLOC=y CONFIG_PROVE_LOCKING=y" $kcsan_kmake_tag $cur_kcsan_kmake_args --kcsan fi }
| |