Messages in this thread | | | Date | Wed, 30 Jun 2021 06:59:11 +0100 | From | Christoph Hellwig <> | Subject | Re: [PATCH rdma-next v1 1/2] lib/scatterlist: Fix wrong update of orig_nents |
| |
On Tue, Jun 29, 2021 at 11:40:01AM +0300, Leon Romanovsky wrote: > 2. Add a new field total_nents to reflect the total number of entries > in the table. This is required for the release flow (sg_free_table). > This filed should be used internally only by scatterlist.
No, please don't bloat the common structure.
> + /* The fields below should be used internally only by > + * scatterlist implementation. > + */
And this is not the way kernel comments work.
| |