Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Wed, 30 Jun 2021 11:42:20 +0200 | Subject | Re: [PATCH 3/3 v2] sh: fix READ/WRITE redefinition warnings |
| |
Hi Adrian,
On Wed, Jun 30, 2021 at 11:36 AM John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> wrote: > On 6/28/21 12:05 AM, Randy Dunlap wrote: > > kernel.h defines READ and WRITE, so rename the SH math-emu macros > > to MREAD and MWRITE. > > > > Fixes these warnings: > > > > ../arch/sh/math-emu/math.c:54: warning: "WRITE" redefined > > 54 | #define WRITE(d,a) ({if(put_user(d, (typeof (d) __user *)a)) return -EFAULT;}) > > In file included from ../arch/sh/math-emu/math.c:10: > > ../include/linux/kernel.h:37: note: this is the location of the previous definition > > 37 | #define WRITE 1 > > ../arch/sh/math-emu/math.c:55: warning: "READ" redefined > > 55 | #define READ(d,a) ({if(get_user(d, (typeof (d) __user *)a)) return -EFAULT;}) > > In file included from ../arch/sh/math-emu/math.c:10: > > ../include/linux/kernel.h:36: note: this is the location of the previous definition > > 36 | #define READ 0 > > > > Fixes: 4b565680d163 ("sh: math-emu support") > > Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> This one no longer applies to Linus' tree:
Worked fine for me. Ah, Linus tree still doesn't have b1deeeb93933d390[1] ("sh: fix trivial misannotations"), which has been lingering in sh/for-next since the beginning or March.
[1] Note to Gmail: No, I don't want to correct this to "b1de b93933d390".
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |