Messages in this thread | | | Subject | Re: [PATCH rdma-next v1 1/2] lib/scatterlist: Fix wrong update of orig_nents | From | Maor Gottlieb <> | Date | Wed, 30 Jun 2021 12:14:04 +0300 |
| |
On 6/30/2021 10:16 AM, Christoph Hellwig wrote: > On Wed, Jun 30, 2021 at 10:02:11AM +0300, Leon Romanovsky wrote: >> Another possible solution is to change __sg_alloc_table()/__sg_alloc_table_from_pages >> to return total_nents and expect from the users to store it internally and pass >> it later to the __sg_free_table(). >> >> Something like that. > Yes, that sounds pretty reasonable.
OK. So we have two options
1. Add another argument (output) to __sg_alloc_table_from_pages and __sg_free_table. The thing is that __sg_free_table gets free_fn as argument while __sg_alloc_table_from_pages doesn't get alloc function. Users will pass NULL as free_fn and scatterlist internally will use sg_kfree.
2. Have dedicated functions to the appending allocations - sg_alloc_table_from_pages_append and sg_free_table_append. With this approach users that use __sg_alloc_table_from_pages not for appending allocation don't need to maintain the new argument.
Christoph, what do you prefer? do you see a better option?
| |