| From | Chen-Yu Tsai <> | Date | Wed, 30 Jun 2021 15:31:24 +0800 | Subject | Re: [PATCH 03/22] clk: mediatek: Fix corner case of tuner_en_reg |
| |
On Thu, Jun 17, 2021 at 7:01 AM Chun-Jie Chen <chun-jie.chen@mediatek.com> wrote: > > On MT8195, tuner_en_reg is moved to register offest 0x0. > If we only judge by tuner_en_reg, it may lead to wrong address. > Add tuner_en_bit to the check condition. And it has been confirmed, > on all the MediaTek SoCs, bit0 of offset 0x0 is always occupied by > clock square control. > > Signed-off-by: Chun-Jie Chen <chun-jie.chen@mediatek.com>
Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
Though you might want to consider converting these types of checks into feature flags.
|