Messages in this thread | | | From | Chen-Yu Tsai <> | Date | Wed, 30 Jun 2021 15:29:16 +0800 | Subject | Re: [PATCH] arm64: dts: mt8183: kukui: use generic pin configs for i2c pins |
| |
On Wed, Jun 30, 2021 at 3:27 PM Chen-Yu Tsai <wenst@chromium.org> wrote: > > On Wed, Jun 30, 2021 at 11:55 AM Hsin-Yi Wang <hsinyi@chromium.org> wrote: > > > > mt8183 i2c pins don't support PUPD register, so change to use generic > > pin configs instead of let it fail and fallback. > > > > Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org> > > Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
You might also want:
Fixes: cd894e274b74 ("arm64: dts: mt8183: Add krane-sku176 board")
> On a side note, the `mediatek,pull-up-adv` property probably should be > merged into `bias-pull-up` with an argument.
| |