[lkml]   [2021]   [Jun]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH v2] hwmon: (scpi-hwmon) shows the negative temperature properly
The scpi hwmon shows the sub-zero temperature in an unsigned integer,
which would confuse the users when the machine works in low temperature
environment. This shows the sub-zero temperature in an signed value and
users can get it properly from sensors.

Signed-off-by: Riwen Lu <>
Tested-by: Xin Chen <>

Changes since v1:
- Add judgment for sensor->info.class. If it is TEMPERATURE situation,
return the sensor value as a signed value, otherwise return it as a
unsigned value.
drivers/hwmon/scpi-hwmon.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/hwmon/scpi-hwmon.c b/drivers/hwmon/scpi-hwmon.c
index 25aac40f2764..45a7e319143d 100644
--- a/drivers/hwmon/scpi-hwmon.c
+++ b/drivers/hwmon/scpi-hwmon.c
@@ -99,7 +99,10 @@ scpi_show_sensor(struct device *dev, struct device_attribute *attr, char *buf)

scpi_scale_reading(&value, sensor);

- return sprintf(buf, "%llu\n", value);
+ if (sensor->info.class == TEMPERATURE)
+ return sprintf(buf, "%lld\n", value);
+ else
+ return sprintf(buf, "%llu\n", value);

static ssize_t

No virus found
Checked by Hillstone Network AntiVirus

 \ /
  Last update: 2021-06-03 10:40    [W:0.039 / U:2.816 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site