Messages in this thread | | | Subject | Re: [PATCH net v2] net: bcmgenet: ensure EXT_ENERGY_DET_MASK is clear | From | Florian Fainelli <> | Date | Tue, 29 Jun 2021 19:34:15 -0700 |
| |
On 6/29/2021 5:14 PM, Doug Berger wrote: > Setting the EXT_ENERGY_DET_MASK bit allows the port energy detection > logic of the internal PHY to prevent the system from sleeping. Some > internal PHYs will report that energy is detected when the network > interface is closed which can prevent the system from going to sleep > if WoL is enabled when the interface is brought down. > > Since the driver does not support waking the system on this logic, > this commit clears the bit whenever the internal PHY is powered up > and the other logic for manipulating the bit is removed since it > serves no useful function. > > Fixes: 1c1008c793fa ("net: bcmgenet: add main driver file") > Signed-off-by: Doug Berger <opendmb@gmail.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com> -- Florian
| |