Messages in this thread | | | Date | Tue, 29 Jun 2021 16:11:01 +0100 | From | Mark Brown <> | Subject | Re: [PATCH v10 2/5] regulator: hi6421v600-regulator: fix platform drvdata |
| |
On Tue, Jun 29, 2021 at 12:31:28PM +0200, Mauro Carvalho Chehab wrote:
> platform drvdata can't be used inside the regulator driver, > as this is already used by the MFD and SPMI drivers.
Can you clarify what exactly is using which platform drvdata already? This all feels very confused and I can't tell what the problem that's being fixed is, if it's a real issue or how this fixes it.
> drivers/misc/hi6421v600-irq.c | 9 ++-- > drivers/regulator/hi6421v600-regulator.c | 49 +++++++++++---------- > drivers/staging/hikey9xx/hi6421-spmi-pmic.c | 18 +++----- > include/linux/mfd/hi6421-spmi-pmic.h | 25 -----------
I'm especially nervous about the core driver still being in staging perhaps meaning there's some issue with it doing odd and confusing things. [unhandled content-type:application/pgp-signature] | |