Messages in this thread | | | Date | Tue, 29 Jun 2021 14:43:37 +0530 | From | Viresh Kumar <> | Subject | Re: [PATCH v10] i2c: virtio: add a virtio i2c frontend driver |
| |
On 29-06-21, 10:30, Wolfram Sang wrote: > > > 3. It seems the I2C core takes care of locking already, so is it safy to > > remove "struct mutex lock in struct virtio_i2c"? > > Looks to me like the mutex is only to serialize calls to > virtio_i2c_xfer(). Then, it can go. The core does locking. See, we have > i2c_transfer and __i2c_transfer, the unlocked version.
Right, this is what I have been suggesting as well.
So do you want Jie to send V11 now after fixing these three issues, or you have more concerns ?
-- viresh
| |