lkml.org 
[lkml]   [2021]   [Jun]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 44/71] net: fec_ptp: add clock rate zero check
    Date
    From: Fugang Duan <fugang.duan@nxp.com>

    commit cb3cefe3f3f8af27c6076ef7d1f00350f502055d upstream.

    Add clock rate zero check to fix coverity issue of "divide by 0".

    Fixes: commit 85bd1798b24a ("net: fec: fix spin_lock dead lock")
    Signed-off-by: Fugang Duan <fugang.duan@nxp.com>
    Signed-off-by: Joakim Zhang <qiangqing.zhang@nxp.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/ethernet/freescale/fec_ptp.c | 4 ++++
    1 file changed, 4 insertions(+)

    diff --git a/drivers/net/ethernet/freescale/fec_ptp.c b/drivers/net/ethernet/freescale/fec_ptp.c
    index 123181612595..031d4b3a544c 100644
    --- a/drivers/net/ethernet/freescale/fec_ptp.c
    +++ b/drivers/net/ethernet/freescale/fec_ptp.c
    @@ -586,6 +586,10 @@ void fec_ptp_init(struct platform_device *pdev)
    fep->ptp_caps.enable = fec_ptp_enable;

    fep->cycle_speed = clk_get_rate(fep->clk_ptp);
    + if (!fep->cycle_speed) {
    + fep->cycle_speed = NSEC_PER_SEC;
    + dev_err(&fep->pdev->dev, "clk_ptp clock rate is zero\n");
    + }
    fep->ptp_inc = NSEC_PER_SEC / fep->cycle_speed;

    spin_lock_init(&fep->tmreg_lock);
    --
    2.30.2
    \
     
     \ /
      Last update: 2021-06-28 17:23    [W:4.070 / U:0.232 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site