lkml.org 
[lkml]   [2021]   [Jun]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 17/71] dmaengine: rcar-dmac: Fix PM reference leak in rcar_dmac_probe()
    Date
    From: Zou Wei <zou_wei@huawei.com>

    [ Upstream commit dea8464ddf553803382efb753b6727dbf3931d06 ]

    pm_runtime_get_sync will increment pm usage counter even it failed.
    Forgetting to putting operation will result in reference leak here.
    Fix it by replacing it with pm_runtime_resume_and_get to keep usage
    counter balanced.

    Reported-by: Hulk Robot <hulkci@huawei.com>
    Signed-off-by: Zou Wei <zou_wei@huawei.com>
    Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
    Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
    Link: https://lore.kernel.org/r/1622442963-54095-1-git-send-email-zou_wei@huawei.com
    Signed-off-by: Vinod Koul <vkoul@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/dma/sh/rcar-dmac.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/dma/sh/rcar-dmac.c b/drivers/dma/sh/rcar-dmac.c
    index 3993ab65c62c..89eb9ea25814 100644
    --- a/drivers/dma/sh/rcar-dmac.c
    +++ b/drivers/dma/sh/rcar-dmac.c
    @@ -1855,7 +1855,7 @@ static int rcar_dmac_probe(struct platform_device *pdev)

    /* Enable runtime PM and initialize the device. */
    pm_runtime_enable(&pdev->dev);
    - ret = pm_runtime_get_sync(&pdev->dev);
    + ret = pm_runtime_resume_and_get(&pdev->dev);
    if (ret < 0) {
    dev_err(&pdev->dev, "runtime PM get sync failed (%d)\n", ret);
    return ret;
    --
    2.30.2
    \
     
     \ /
      Last update: 2021-06-28 17:10    [W:4.071 / U:0.232 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site