lkml.org 
[lkml]   [2021]   [Jun]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 19/88] dmaengine: QCOM_HIDMA_MGMT depends on HAS_IOMEM
    Date
    From: Randy Dunlap <rdunlap@infradead.org>

    [ Upstream commit 0cfbb589d67f16fa55b26ae02b69c31b52e344b1 ]

    When CONFIG_HAS_IOMEM is not set/enabled, certain iomap() family
    functions [including ioremap(), devm_ioremap(), etc.] are not
    available.
    Drivers that use these functions should depend on HAS_IOMEM so that
    they do not cause build errors.

    Rectifies these build errors:
    s390-linux-ld: drivers/dma/qcom/hidma_mgmt.o: in function `hidma_mgmt_probe':
    hidma_mgmt.c:(.text+0x780): undefined reference to `devm_ioremap_resource'
    s390-linux-ld: drivers/dma/qcom/hidma_mgmt.o: in function `hidma_mgmt_init':
    hidma_mgmt.c:(.init.text+0x126): undefined reference to `of_address_to_resource'
    s390-linux-ld: hidma_mgmt.c:(.init.text+0x16e): undefined reference to `of_address_to_resource'

    Fixes: 67a2003e0607 ("dmaengine: add Qualcomm Technologies HIDMA channel driver")
    Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
    Reported-by: kernel test robot <lkp@intel.com>
    Cc: Sinan Kaya <okaya@codeaurora.org>
    Cc: Vinod Koul <vkoul@kernel.org>
    Cc: dmaengine@vger.kernel.org
    Link: https://lore.kernel.org/r/20210522021313.16405-3-rdunlap@infradead.org
    Signed-off-by: Vinod Koul <vkoul@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/dma/qcom/Kconfig | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/dma/qcom/Kconfig b/drivers/dma/qcom/Kconfig
    index a7761c4025f4..a97c7123d913 100644
    --- a/drivers/dma/qcom/Kconfig
    +++ b/drivers/dma/qcom/Kconfig
    @@ -9,6 +9,7 @@ config QCOM_BAM_DMA

    config QCOM_HIDMA_MGMT
    tristate "Qualcomm Technologies HIDMA Management support"
    + depends on HAS_IOMEM
    select DMA_ENGINE
    help
    Enable support for the Qualcomm Technologies HIDMA Management.
    --
    2.30.2
    \
     
     \ /
      Last update: 2021-06-28 17:08    [W:4.160 / U:0.256 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site