lkml.org 
[lkml]   [2021]   [Jun]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 010/109] scsi: target: core: Fix warning on realtime kernels
    Date
    From: Maurizio Lombardi <mlombard@redhat.com>

    [ Upstream commit 515da6f4295c2c42b8c54572cce3d2dd1167c41e ]

    On realtime kernels, spin_lock_irq*(spinlock_t) do not disable the
    interrupts, a call to irqs_disabled() will return false thus firing a
    warning in __transport_wait_for_tasks().

    Remove the warning and also replace assert_spin_locked() with
    lockdep_assert_held()

    Link: https://lore.kernel.org/r/20210531121326.3649-1-mlombard@redhat.com
    Reviewed-by: Bart Van Assche <bvanassche@acm.org>
    Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/target/target_core_transport.c | 4 +---
    1 file changed, 1 insertion(+), 3 deletions(-)

    diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c
    index bdada97cd4fe..9c60a090cfd1 100644
    --- a/drivers/target/target_core_transport.c
    +++ b/drivers/target/target_core_transport.c
    @@ -2982,9 +2982,7 @@ __transport_wait_for_tasks(struct se_cmd *cmd, bool fabric_stop,
    __releases(&cmd->t_state_lock)
    __acquires(&cmd->t_state_lock)
    {
    -
    - assert_spin_locked(&cmd->t_state_lock);
    - WARN_ON_ONCE(!irqs_disabled());
    + lockdep_assert_held(&cmd->t_state_lock);

    if (fabric_stop)
    cmd->transport_state |= CMD_T_FABRIC_STOP;
    --
    2.30.2
    \
     
     \ /
      Last update: 2021-06-28 16:55    [W:4.172 / U:0.240 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site