lkml.org 
[lkml]   [2021]   [Jun]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 011/109] ethernet: myri10ge: Fix missing error code in myri10ge_probe()
    Date
    From: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

    [ Upstream commit f336d0b93ae978f12c5e27199f828da89b91e56a ]

    The error code is missing in this code scenario, add the error code
    '-EINVAL' to the return value 'status'.

    Eliminate the follow smatch warning:

    drivers/net/ethernet/myricom/myri10ge/myri10ge.c:3818 myri10ge_probe()
    warn: missing error code 'status'.

    Reported-by: Abaci Robot <abaci@linux.alibaba.com>
    Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/myricom/myri10ge/myri10ge.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/net/ethernet/myricom/myri10ge/myri10ge.c b/drivers/net/ethernet/myricom/myri10ge/myri10ge.c
    index 6789eed78ff7..3bc570c46f81 100644
    --- a/drivers/net/ethernet/myricom/myri10ge/myri10ge.c
    +++ b/drivers/net/ethernet/myricom/myri10ge/myri10ge.c
    @@ -3853,6 +3853,7 @@ static int myri10ge_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
    dev_err(&pdev->dev,
    "invalid sram_size %dB or board span %ldB\n",
    mgp->sram_size, mgp->board_span);
    + status = -EINVAL;
    goto abort_with_ioremap;
    }
    memcpy_fromio(mgp->eeprom_strings,
    --
    2.30.2
    \
     
     \ /
      Last update: 2021-06-28 16:55    [W:4.116 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site