Messages in this thread | | | Subject | Re: [PATCH v2] clk: qcom: clk-alpha-pll: fix CAL_L write in alpha_pll_fabia_prepare | From | Taniya Das <> | Date | Mon, 28 Jun 2021 16:25:51 +0530 |
| |
Reviewed-by: Taniya Das <tdas@codeaurora.org>
On 6/9/2021 7:58 AM, Jonathan Marek wrote: > Caught this when looking at alpha-pll code. Untested but it is clear that > this was intended to write to PLL_CAL_L_VAL and not PLL_ALPHA_VAL. > > Fixes: 691865bad627 ("clk: qcom: clk-alpha-pll: Add support for Fabia PLL calibration") > Signed-off-by: Jonathan Marek <jonathan@marek.ca> > --- > drivers/clk/qcom/clk-alpha-pll.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/qcom/clk-alpha-pll.c b/drivers/clk/qcom/clk-alpha-pll.c > index 94b53c7db2f7f..eaedcceb766f9 100644 > --- a/drivers/clk/qcom/clk-alpha-pll.c > +++ b/drivers/clk/qcom/clk-alpha-pll.c > @@ -1255,7 +1255,7 @@ static int alpha_pll_fabia_prepare(struct clk_hw *hw) > return ret; > > /* Setup PLL for calibration frequency */ > - regmap_write(pll->clkr.regmap, PLL_ALPHA_VAL(pll), cal_l); > + regmap_write(pll->clkr.regmap, PLL_CAL_L_VAL(pll), cal_l); > > /* Bringup the PLL at calibration frequency */ > ret = clk_alpha_pll_enable(hw); >
-- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation.
--
| |