Messages in this thread | | | Subject | Re: [PATCH] btrfs: remove unneeded variable: "ret" | From | Qu Wenruo <> | Date | Mon, 28 Jun 2021 17:21:33 +0800 |
| |
On 2021/6/28 下午4:30, 13145886936@163.com wrote: > From: gushengxian <gushengxian@yulong.com> > > Remove unneeded variable: "ret". > > Signed-off-by: gushengxian <13145886936@163.com> > Signed-off-by: gushengxian <gushengxian@yulong.com>
Is this detected by some script?
Mind to share the script and run it against the whole btrfs code base?
Thanks, Qu
> --- > fs/btrfs/disk-io.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c > index b117dd3b8172..7e65a54b7839 100644 > --- a/fs/btrfs/disk-io.c > +++ b/fs/btrfs/disk-io.c > @@ -4624,7 +4624,6 @@ static int btrfs_destroy_delayed_refs(struct btrfs_transaction *trans, > struct rb_node *node; > struct btrfs_delayed_ref_root *delayed_refs; > struct btrfs_delayed_ref_node *ref; > - int ret = 0; > > delayed_refs = &trans->delayed_refs; > > @@ -4632,7 +4631,7 @@ static int btrfs_destroy_delayed_refs(struct btrfs_transaction *trans, > if (atomic_read(&delayed_refs->num_entries) == 0) { > spin_unlock(&delayed_refs->lock); > btrfs_debug(fs_info, "delayed_refs has NO entry"); > - return ret; > + return 0; > } > > while ((node = rb_first_cached(&delayed_refs->href_root)) != NULL) { > @@ -4695,7 +4694,7 @@ static int btrfs_destroy_delayed_refs(struct btrfs_transaction *trans, > > spin_unlock(&delayed_refs->lock); > > - return ret; > + return 0; > } > > static void btrfs_destroy_delalloc_inodes(struct btrfs_root *root) >
| |