Messages in this thread Patch in this message | | | From | Nanyong Sun <> | Subject | [PATCH 4/6] nilfs2: fix memory leak in nilfs_sysfs_delete_##name##_group | Date | Tue, 29 Jun 2021 10:25:54 +0800 |
| |
The kobject_put() should be used to cleanup the memory associated with the kobject insead of kobject_del. See the section "Kobject removal" of "Documentation/core-api/kobject.rst".
Signed-off-by: Nanyong Sun <sunnanyong@huawei.com> --- fs/nilfs2/sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/nilfs2/sysfs.c b/fs/nilfs2/sysfs.c index 6305e4ef7e39..d989e6500bd7 100644 --- a/fs/nilfs2/sysfs.c +++ b/fs/nilfs2/sysfs.c @@ -84,7 +84,7 @@ static int nilfs_sysfs_create_##name##_group(struct the_nilfs *nilfs) \ } \ static void nilfs_sysfs_delete_##name##_group(struct the_nilfs *nilfs) \ { \ - kobject_del(&nilfs->ns_##parent_name##_subgroups->sg_##name##_kobj); \ + kobject_put(&nilfs->ns_##parent_name##_subgroups->sg_##name##_kobj); \ } /************************************************************************ -- 2.18.0.huawei.25
| |