Messages in this thread | | | From | "Voon, Weifeng" <> | Subject | RE: [PATCH net-next V1 3/4] net: stmmac: Reconfigure the PHY WOL settings in stmmac_resume() | Date | Mon, 28 Jun 2021 07:54:14 +0000 |
| |
> > > > No, the interrupt will not be discarded. If the PHY is in > > > > interrupt mode, the interrupt handler will triggers and ISR will > > > > clear the WOL > > > status bit. > > > > The condition here is when the PHY is in polling mode, the PHY > > > > driver does not have any other mechanism to clear the WOL interrupt > status bit. > > > > Hence, we need to go through the PHY set_wol() again. > > > > > > I would say you have a broken setup. If you are explicitly using the > > > interrupt as a wakeup source, you need to be servicing the > > > interrupt. You cannot use polled mode. > > > > Sorry for the confusion. But I would like to clarify the I should use > > the term of "WOL event status" rather than "WOL interrupt status". > > For interrupt mode, clearing the "WOL interrupt status" register will > > auto clear the "WOL event status". > > For polling mode, the phy driver can manually clear the "WOL event > > status" by setting 1 to "Clear WOL Status" bit. > > If WOL raises an interrupt signal from the PHY, but the PHY interrupt > signal is not wired, how does the wakeup happen? What is the PHY interrupt > wired to?
The PHY WOL event signal is wired directly to the PMC. The PMC will detect the triggered WOL event signal and wakeup the system.
Weifeng
| |