lkml.org 
[lkml]   [2021]   [Jun]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 72/88] mac80211: remove warning in ieee80211_get_sband()
    Date
    From: Johannes Berg <johannes.berg@intel.com>

    [ Upstream commit 0ee4d55534f82a0624701d0bb9fc2304d4529086 ]

    Syzbot reports that it's possible to hit this from userspace,
    by trying to add a station before any other connection setup
    has been done. Instead of trying to catch this in some other
    way simply remove the warning, that will appropriately reject
    the call from userspace.

    Reported-by: syzbot+7716dbc401d9a437890d@syzkaller.appspotmail.com
    Link: https://lore.kernel.org/r/20210517164715.f537da276d17.Id05f40ec8761d6a8cc2df87f1aa09c651988a586@changeid
    Signed-off-by: Johannes Berg <johannes.berg@intel.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    net/mac80211/ieee80211_i.h | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/net/mac80211/ieee80211_i.h b/net/mac80211/ieee80211_i.h
    index 790c771e8108..0d4f7258b243 100644
    --- a/net/mac80211/ieee80211_i.h
    +++ b/net/mac80211/ieee80211_i.h
    @@ -1393,7 +1393,7 @@ ieee80211_get_sband(struct ieee80211_sub_if_data *sdata)
    rcu_read_lock();
    chanctx_conf = rcu_dereference(sdata->vif.chanctx_conf);

    - if (WARN_ON_ONCE(!chanctx_conf)) {
    + if (!chanctx_conf) {
    rcu_read_unlock();
    return NULL;
    }
    --
    2.30.2
    \
     
     \ /
      Last update: 2021-06-28 17:40    [W:8.196 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site