lkml.org 
[lkml]   [2021]   [Jun]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 10/57] rtnetlink: Fix missing error code in rtnl_bridge_notify()
    Date
    From: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

    [ Upstream commit a8db57c1d285c758adc7fb43d6e2bad2554106e1 ]

    The error code is missing in this code scenario, add the error code
    '-EINVAL' to the return value 'err'.

    Eliminate the follow smatch warning:

    net/core/rtnetlink.c:4834 rtnl_bridge_notify() warn: missing error code
    'err'.

    Reported-by: Abaci Robot <abaci@linux.alibaba.com>
    Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    net/core/rtnetlink.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
    index e2a0aed52983..11d2da8abd73 100644
    --- a/net/core/rtnetlink.c
    +++ b/net/core/rtnetlink.c
    @@ -3240,8 +3240,10 @@ static int rtnl_bridge_notify(struct net_device *dev)
    if (err < 0)
    goto errout;

    - if (!skb->len)
    + if (!skb->len) {
    + err = -EINVAL;
    goto errout;
    + }

    rtnl_notify(skb, net, 0, RTNLGRP_LINK, NULL, GFP_ATOMIC);
    return 0;
    --
    2.30.2
    \
     
     \ /
      Last update: 2021-06-28 17:25    [W:4.259 / U:1.488 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site