lkml.org 
[lkml]   [2021]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/2] nvme-fc: Update hardware queues before using them
From
Date
On 6/25/2021 3:16 AM, Daniel Wagner wrote:
> In case the number of hardware queues changes, do the update the
> tagset and ctx to hctx first before using the mapping to recreate and
> connnect the IO queues.
>
> Signed-off-by: Daniel Wagner <dwagner@suse.de>
> ---
> drivers/nvme/host/fc.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/nvme/host/fc.c b/drivers/nvme/host/fc.c
> index 8a3c4814d21b..a9645cd89eca 100644

Makes sense. Thanks. Although it does bring up that perhaps, if the
hw queue count changes, thus it no longer matches what was set on the
target, the new value should be set on the target to release resources
on the target.

Note: the same behavior exists in the other transports as we all started
from the same lineage. So those should be updated as well. Granted
you'll need to break out the queue count set and checking which was done
on fc but not on the other transports.

Reviewed-by: James Smart <jsmart2021@gmail.com>

-- james

\
 
 \ /
  Last update: 2021-06-27 15:47    [W:0.118 / U:1.928 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site