Messages in this thread | | | Date | Sun, 27 Jun 2021 17:01:28 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [RESEND PATCH] x86/tools/relocs: add __printf attribute to die() |
| |
On Fri, Jun 25, 2021 at 11:07:28PM +0200, Borislav Petkov wrote: > On Fri, Jun 25, 2021 at 01:38:51PM -0700, H. Peter Anvin wrote: > > 64-bit cross build on a 32-bit platform... or Windows. > > Meh, nobody cares about those... :) > > Hmm, so looking at the PRI* inttypes.h things again, they're C99 and > they kinda look more elegant as they don't make us cast stuff. > > So how does that look? > > --- > > diff --git a/arch/x86/tools/relocs.c b/arch/x86/tools/relocs.c > index 04c5a44b9682..2582991ba216 100644 > --- a/arch/x86/tools/relocs.c > +++ b/arch/x86/tools/relocs.c > @@ -26,6 +26,9 @@ static struct relocs relocs32; > #if ELF_BITS == 64 > static struct relocs relocs32neg; > static struct relocs relocs64; > +#define FMT PRIu64 > +#else > +#define FMT PRIu32 > #endif
<snip>
This works for me! It should fix the static checking tool that keeps tripping over this pointless warning :)
Want to turn it into a real patch?
thanks,
greg k-h
| |