Messages in this thread | | | Subject | Re: [PATCH 1/1] clk: tegra: tegra124-emc: Fix possible memory leak | From | Stephen Boyd <> | Date | Fri, 25 Jun 2021 16:31:13 -0700 |
| |
Quoting Zhen Lei (2021-06-17 01:27:59) > When krealloc() fails to expand the memory and returns NULL, the original > memory is not released. In this case, the original "timings" scale should > be maintained. > > Fixes: 888ca40e2843 ("clk: tegra: emc: Support multiple RAM codes") > Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> > ---
Looks correct, but when does krealloc() return NULL? My read of the kerneldoc is that it would return the original memory if the new allocation "failed".
Reviewed-by: Stephen Boyd <sboyd@kernel.org>
| |