Messages in this thread | | | From | "Brelinski, TonyX" <> | Subject | RE: [Intel-wired-lan] [PATCH] igb: Avoid memcpy() over-reading of ETH_SS_STATS | Date | Fri, 25 Jun 2021 22:41:37 +0000 |
| |
> -----Original Message----- > From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of > Kees Cook > Sent: Wednesday, June 16, 2021 12:53 PM > To: netdev@vger.kernel.org > Cc: Kees Cook <keescook@chromium.org>; linux-kernel@vger.kernel.org; > linux-hardening@vger.kernel.org; Jakub Kicinski <kuba@kernel.org>; intel- > wired-lan@lists.osuosl.org; David S. Miller <davem@davemloft.net> > Subject: [Intel-wired-lan] [PATCH] igb: Avoid memcpy() over-reading of > ETH_SS_STATS > > In preparation for FORTIFY_SOURCE performing compile-time and run-time > field bounds checking for memcpy(), memmove(), and memset(), avoid > intentionally reading across neighboring array fields. > > The memcpy() is copying the entire structure, not just the first array. > Adjust the source argument so the compiler can do appropriate bounds > checking. > > Signed-off-by: Kees Cook <keescook@chromium.org> > --- > drivers/net/ethernet/intel/igb/igb_ethtool.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-)
Tested-by: Tony Brelinski <tonyx.brelinski@intel.com> (A Contingent Worker at Intel)
| |