Messages in this thread | | | From | John Ogness <> | Subject | Re: [PATCH printk v3 6/6] printk: syslog: close window between wait and read | Date | Fri, 25 Jun 2021 16:20:09 +0206 |
| |
On 2021-06-25, Steven Rostedt <rostedt@goodmis.org> wrote: >> + * @syslog_lock is held when entering the read loop to prevent >> + * another reader from modifying @syslog_seq. > > You should add to the above comment: > > * And the @syslog_lock is released before exiting the loop. > > Because it's not normal to enter a loop locked, and have it unlocked > when exiting the loop. And I can envision in the future, someone might > add a break (for error) while still holding the lock.
Agreed. Thanks.
John
| |