Messages in this thread | | | Date | Fri, 25 Jun 2021 14:12:39 +0200 (CEST) | From | Jiri Kosina <> | Subject | Re: [PATCH] HID: intel-ish-hid: use async resume function |
| |
On Sun, 13 Jun 2021, Ye Xiang wrote:
> ISH IPC driver uses asynchronous workqueue to do resume now, but there is > a potential timing issue: when child devices resume before bus driver, it > will cause child devices resume failed and cannot be recovered until > reboot. The current implementation in this case do wait for IPC to resume > but fail to accommodate for a case when there is no ISH reboot and soft > resume is taking time. This issue is apparent on Tiger Lake platform with > 5.11.13 kernel when doing suspend to idle then resume(s0ix) test. To > resolve this issue, we change ISHTP HID client to use asynchronous resume > callback too. In the asynchronous resume callback, it waits for the ISHTP > resume done event, and then notify ISHTP HID client link ready. > > Signed-off-by: Ye Xiang <xiang.ye@intel.com>
Srinivas, can I please get your Ack for this one?
Thanks,
-- Jiri Kosina SUSE Labs
| |