Messages in this thread | | | From | Coiby Xu <> | Date | Thu, 24 Jun 2021 19:34:56 +0800 | Subject | Re: [RFC 04/19] staging: qlge: add qlge_* prefix to avoid namespace clashes |
| |
On Tue, Jun 22, 2021 at 04:55:42PM +0900, Benjamin Poirier wrote: >On 2021-06-21 21:48 +0800, Coiby Xu wrote: >> This patch extends commit f8c047be540197ec69cde33e00e82d23961459ea >> ("staging: qlge: use qlge_* prefix to avoid namespace clashes with other qlogic drivers") >> to add qlge_ prefix to rx_ring and tx_ring related structures. > >There are still many struct, defines and enums in qlge.h which don't >have a prefix or mix ql_ and qlge_, some of which conflict with other >instances elsewhere in the kernel. >ex: QL_ADAPTER_UP > >I think they should all be changed, not just the ones have a conflict >today.
I'll fix them in next version. Thanks for the reminder!
-- Best regards, Coiby
| |