Messages in this thread | | | From | Coiby Xu <> | Date | Thu, 24 Jun 2021 19:22:45 +0800 | Subject | Re: [RFC 13/19] staging: qlge: rewrite do while loop as for loop in qlge_sem_spinlock |
| |
On Tue, Jun 22, 2021 at 10:20:36AM +0300, Dan Carpenter wrote: >On Mon, Jun 21, 2021 at 09:48:56PM +0800, Coiby Xu wrote: >> Since wait_count=30 > 0, the for loop is equivalent to do while >> loop. This commit also replaces 100 with UDELAY_DELAY. >> >> Signed-off-by: Coiby Xu <coiby.xu@gmail.com> >> --- >> drivers/staging/qlge/qlge_main.c | 7 ++++--- >> 1 file changed, 4 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c >> index c5e161595b1f..2d2405be38f5 100644 >> --- a/drivers/staging/qlge/qlge_main.c >> +++ b/drivers/staging/qlge/qlge_main.c >> @@ -140,12 +140,13 @@ static int qlge_sem_trylock(struct qlge_adapter *qdev, u32 sem_mask) >> int qlge_sem_spinlock(struct qlge_adapter *qdev, u32 sem_mask) >> { >> unsigned int wait_count = 30; >> + int count; >> >> - do { >> + for (count = 0; count < wait_count; count++) { >> if (!qlge_sem_trylock(qdev, sem_mask)) >> return 0; >> - udelay(100); >> - } while (--wait_count); >> + udelay(UDELAY_DELAY); > >This is an interesting way to silence the checkpatch udelay warning. ;)
I didn't know this could silence the warning :)
> >regards, >dan carpenter >
-- Best regards, Coiby
| |