Messages in this thread | | | Date | Thu, 24 Jun 2021 12:31:33 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH v2] media: atomisp: fix the uninitialized use and rename "retvalue" |
| |
On Thu, Jun 24, 2021 at 03:17:17AM +0000, Yizhuo wrote: > Inside function mt9m114_detect(), variable "retvalue" could > be uninitialized if mt9m114_read_reg() returns error, however, it > is used in the later if statement, which is potentially unsafe. > > The local variable "retvalue" is renamed to "model" to avoid > confusion. > > Signed-off-by: Yizhuo <yzhai003@ucr.edu>
Please add a Fixes tag.
regards, dan carpenter
| |