Messages in this thread | | | Subject | Re: [PATCH v3] Documentation, dt, numa: Add note to empty NUMA node | From | Randy Dunlap <> | Date | Thu, 24 Jun 2021 20:47:19 -0700 |
| |
On 6/24/21 9:30 PM, Gavin Shan wrote: > The empty NUMA nodes, where no memory resides in, are allowed. For > these empty NUMA nodes, the 'len' of 'reg' property is zero. These > empty NUMA node IDs are still valid and parsed. I finds difficulty > to get where it's properly documented. > > So lets add note to empty NUMA nodes in the NUMA binding doc. > > Signed-off-by: Gavin Shan <gshan@redhat.com> > --- > Documentation/devicetree/bindings/numa.txt | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/numa.txt b/Documentation/devicetree/bindings/numa.txt > index 21b35053ca5a..edf728cff155 100644 > --- a/Documentation/devicetree/bindings/numa.txt > +++ b/Documentation/devicetree/bindings/numa.txt > @@ -109,6 +109,10 @@ Example: > Dual socket system consists of 2 boards connected through ccn bus and > each board having one socket/soc of 8 cpus, memory and pci bus. > > +Note that the empty NUMA nodes, which no memory resides in, are allowed.
I would write that without "the":
+Note that empty NUMA nodes, which no memory resides in, are allowed.
BTW, AFAIK, NUMA nodes may contain memory, CPU(s), or I/O -- any one, two, or three, without the other types of resources being present.
> +Their NUMA node IDs are still valid so that memory can be added into these > +NUMA nodes through hotplug afterwards. > + > memory@c00000 { > device_type = "memory"; > reg = <0x0 0xc00000 0x0 0x80000000>;
OT: is your system clock off by a couple of hours? Your emails seem to be from in the future.
Thanks.
| |