Messages in this thread | | | Subject | Re: [PATCH] Documentation, dt, numa: Add note to empty NUMA node | From | Gavin Shan <> | Date | Fri, 25 Jun 2021 12:10:33 +1000 |
| |
On 6/24/21 5:44 PM, Gavin Shan wrote: > On 6/24/21 3:37 PM, Randy Dunlap wrote: >> On 6/23/21 9:58 PM, Gavin Shan wrote: >>> On 6/24/21 12:14 PM, Randy Dunlap wrote: >>>> On 6/23/21 8:37 PM, Gavin Shan wrote: >>>>> The empty NUMA nodes, where no memory resides in, are allowed. For >>>>> these empty NUMA nodes, the 'len' of 'reg' property is zero. These >>>>> empty NUMA node IDs are still valid and parsed. I finds difficulty >>>>> to get where it's properly documented. >>>>> >>>>> So lets add note to empty NUMA nodes in the NUMA binding doc. >>>>> >>>>> Signed-off-by: Gavin Shan <gshan@redhat.com> >>>>> --- >>>>> Documentation/devicetree/bindings/numa.txt | 4 ++++ >>>>> 1 file changed, 4 insertions(+) >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/numa.txt b/Documentation/devicetree/bindings/numa.txt >>>>> index 21b35053ca5a..c564705c0eac 100644 >>>>> --- a/Documentation/devicetree/bindings/numa.txt >>>>> +++ b/Documentation/devicetree/bindings/numa.txt >>>>> @@ -109,6 +109,10 @@ Example: >>>>> Dual socket system consists of 2 boards connected through ccn bus and >>>>> each board having one socket/soc of 8 cpus, memory and pci bus. >>>>> +Note that the empty NUMA nodes, which no memory resides in, are allowed >>>> >>>> Missing period at end of the sentence above. >>>> >>> >>> Oh, Yes. Thanks, Randy. I will replace "resides in" with "resides in period" >>> in v2. >> >> Cute. Would it help if I replaced "period" with Missing "full stop" or '.' at the end >> of the sentence? >> > > Ah, yes, '.' is needed either. Do you want me to post a new revision or you > modify it right away? I don't know how device-tree patches get merged :) >
Randy, I just posted v2 to include changes suggested by you. Could you help to have a quick check when getting a chance?
>>>>> +Their NUMA node IDs are still valid so that memory can be added into these >>>>> +NUMA nodes through hotplug afterwards. >>>>> + >>>>> memory@c00000 { >>>>> device_type = "memory"; >>>>> reg = <0x0 0xc00000 0x0 0x80000000>; >>>
[...]
Thanks, Gavin
| |