lkml.org 
[lkml]   [2021]   [Jun]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 08/23] staging: rtl8188eu: remove all RT_TRACE calls from core/rtw_mlme_ext.c
    Date
    Remove all RT_TRACE calls from core/rtw_mlme_ext.c as this macro is
    unnecessary, and these calls are dubious in terms of necessity.
    Removing all calls will ultimately allow the removal of the macro
    itself.

    Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
    ---
    drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 41 +++----------------
    1 file changed, 5 insertions(+), 36 deletions(-)

    diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c b/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
    index e237df794db7..25653ebfaafd 100644
    --- a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
    +++ b/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
    @@ -594,8 +594,6 @@ static int issue_probereq(struct adapter *padapter,
    struct mlme_ext_priv *pmlmeext = &padapter->mlmeextpriv;
    int bssrate_len = 0;

    - RT_TRACE(_module_rtl871x_mlme_c_, _drv_notice_, ("+%s\n", __func__));
    -
    pmgntframe = alloc_mgtxmitframe(pxmitpriv);
    if (!pmgntframe)
    goto exit;
    @@ -656,9 +654,6 @@ static int issue_probereq(struct adapter *padapter,

    pattrib->last_txcmdsz = pattrib->pktlen;

    - RT_TRACE(_module_rtl871x_mlme_c_, _drv_notice_,
    - ("issuing probe_req, tx_len=%d\n", pattrib->last_txcmdsz));
    -
    if (wait_ack) {
    ret = dump_mgntframe_and_wait_ack(padapter, pmgntframe);
    } else {
    @@ -2095,8 +2090,6 @@ static void start_create_ibss(struct adapter *padapter)

    /* issue beacon */
    if (send_beacon(padapter) == _FAIL) {
    - RT_TRACE(_module_rtl871x_mlme_c_, _drv_err_, ("issuing beacon frame fail....\n"));
    -
    report_join_res(padapter, -1);
    pmlmeinfo->state = WIFI_FW_NULL_STATE;
    } else {
    @@ -2269,9 +2262,6 @@ static void process_80211d(struct adapter *padapter, struct wlan_bssid_ex *bssid
    memset(country, 0, 4);
    memcpy(country, p, 3);
    p += 3;
    - RT_TRACE(_module_rtl871x_mlme_c_, _drv_notice_,
    - ("%s: 802.11d country =%s\n", __func__, country));
    -
    i = 0;
    while ((ie - p) >= 3) {
    fcn = *(p++);
    @@ -2365,12 +2355,8 @@ static void process_80211d(struct adapter *padapter, struct wlan_bssid_ex *bssid
    i = 0;
    while ((i < MAX_CHANNEL_NUM) && (chplan_new[i].ChannelNum != 0)) {
    if (chplan_new[i].ChannelNum == channel) {
    - if (chplan_new[i].ScanType == SCAN_PASSIVE) {
    + if (chplan_new[i].ScanType == SCAN_PASSIVE)
    chplan_new[i].ScanType = SCAN_ACTIVE;
    - RT_TRACE(_module_rtl871x_mlme_c_, _drv_notice_,
    - ("%s: change channel %d scan type from passive to active\n",
    - __func__, channel));
    - }
    break;
    }
    i++;
    @@ -3859,17 +3845,8 @@ void mgt_dispatcher(struct adapter *padapter, struct recv_frame *precv_frame)
    u8 *pframe = precv_frame->pkt->data;
    struct sta_info *psta = rtw_get_stainfo(&padapter->stapriv, GetAddr2Ptr(pframe));

    - RT_TRACE(_module_rtl871x_mlme_c_, _drv_info_,
    - ("+%s: type(0x%x) subtype(0x%x)\n", __func__,
    - (unsigned int)GetFrameType(pframe),
    - (unsigned int)GetFrameSubType(pframe)));
    -
    - if (GetFrameType(pframe) != WIFI_MGT_TYPE) {
    - RT_TRACE(_module_rtl871x_mlme_c_, _drv_err_,
    - ("%s: type(0x%x) error!\n", __func__,
    - (unsigned int)GetFrameType(pframe)));
    + if (GetFrameType(pframe) != WIFI_MGT_TYPE)
    return;
    - }

    /* receive the frames that ra(a1) is my address or ra(a1) is bc address. */
    if (memcmp(GetAddr1Ptr(pframe), myid(&padapter->eeprompriv), ETH_ALEN) &&
    @@ -3880,10 +3857,8 @@ void mgt_dispatcher(struct adapter *padapter, struct recv_frame *precv_frame)

    index = GetFrameSubType(pframe) >> 4;

    - if (index > 13) {
    - RT_TRACE(_module_rtl871x_mlme_c_, _drv_err_, ("Currently we do not support reserved sub-fr-type=%d\n", index));
    + if (index > 13)
    return;
    - }
    ptable += index;

    if (psta) {
    @@ -5095,19 +5070,13 @@ u8 mlme_evt_hdl(struct adapter *padapter, unsigned char *pbuf)
    evt_code = (u8)((*peventbuf >> 16) & 0xff);

    /* checking if event code is valid */
    - if (evt_code >= MAX_C2HEVT) {
    - RT_TRACE(_module_rtl871x_cmd_c_, _drv_err_, ("\nEvent Code(%d) mismatch!\n", evt_code));
    + if (evt_code >= MAX_C2HEVT)
    goto _abort_event_;
    - }

    /* checking if event size match the event parm size */
    if ((wlanevents[evt_code].parmsize != 0) &&
    - (wlanevents[evt_code].parmsize != evt_sz)) {
    - RT_TRACE(_module_rtl871x_cmd_c_, _drv_err_,
    - ("\nEvent(%d) Parm Size mismatch (%d vs %d)!\n",
    - evt_code, wlanevents[evt_code].parmsize, evt_sz));
    + (wlanevents[evt_code].parmsize != evt_sz))
    goto _abort_event_;
    - }

    peventbuf += 2;

    --
    2.31.1
    \
     
     \ /
      Last update: 2021-06-25 02:09    [W:4.166 / U:0.392 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site