Messages in this thread | | | Date | Thu, 24 Jun 2021 18:44:54 -0500 | From | Bjorn Andersson <> | Subject | Re: [PATCH v9 1/2] dt-bindings: leds: Add Qualcomm Light Pulse Generator binding |
| |
On Thu 24 Jun 18:19 CDT 2021, Marek Behun wrote:
> On Tue, 22 Jun 2021 20:50:38 -0700 > Bjorn Andersson <bjorn.andersson@linaro.org> wrote: > > > +++ b/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml > > The file name should be based on one of the compatible strings, for > example the first one: > qcom,pm8150b-lpg.yaml >
The majority of the files in leds/ are named leds-*.yaml, is this a new scheme for LED bindings?
> > + led@1 { > > + reg = <1>; > > + label = "green:user1"; > > + }; > > `label` is deprecated,
Sorry, I missed the comment in the middle of the description about this. Is there any particular reason why this isn't marked deprecated: true?
> please don't use in new bindings in examples. > Instead use color, function and function-enumerator, i.e. > > color = <LED_COLOR_ID_GREEN>; > function = LED_FUNCTION_xxx; > function-enumerator = <N>; >
Can you point me to something helping me regarding what "function" to use?
For this particular devboard that the example comes from I have 4 LEDs that are named "user1", "user2", "user3" and "user4" in the board documentation. I can make up whatever for the example, but I would like to get the following dts additions follow the expected guidelines.
Regards, Bjorn
| |