Messages in this thread Patch in this message | | | From | Colin King <> | Subject | [PATCH][next] spi: Fix self assignment issue with ancillary->mode | Date | Wed, 23 Jun 2021 18:23:00 +0100 |
| |
From: Colin Ian King <colin.king@canonical.com>
There is an assignment of ancillary->mode to itself which looks dubious since the proceeding comment states that the speed and mode is taken over from the SPI main device, indicating that ancillary->mode should assigned using the value spi->mode. Fix this.
Addresses-Coverity: ("Self assignment") Fixes: 0c79378c0199 ("spi: add ancillary device support") Signed-off-by: Colin Ian King <colin.king@canonical.com> --- drivers/spi/spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index b1b6031961b7..3104055a54e2 100644 --- a/drivers/spi/spi.c +++ b/drivers/spi/spi.c @@ -2184,7 +2184,7 @@ struct spi_device *spi_new_ancillary_device(struct spi_device *spi, /* Take over SPI mode/speed from SPI main device */ ancillary->max_speed_hz = spi->max_speed_hz; - ancillary->mode = ancillary->mode; + ancillary->mode = spi->mode; /* Register the new device */ rc = spi_add_device_locked(ancillary); -- 2.31.1
| |